Update db.py #308
Open
Update db.py #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if dbw is a `batch server` or `score log process server`, I mean this db process do not consume spider log topic, After add `no-incoming` flag to db launch command, group `dbw-spider-log` always log 'Heartbeat session expired. so I add this condition to prevent init spider_log.consumer
|
Hi, have you tested it @clarksun ? Is DBW with --no-incoming option working? |
|
@sibiryakov this is our dbw. https://gist.github.com/clarksun/f651c2200164ce9999428d858e67d81b batch server and scoring server both add --no-incoming, and works well. |
|
Seems like this PR is outdated, so it can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if dbw is a
batch serverorscore log process server, I mean this db process do not consume spider log topic, After addno-incomingflag to db launch command, groupdbw-spider-logalways log 'Heartbeat session expired. so I add this condition to prevent init spider_log.consumer