Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have done some workaround across implementing ActiveMq to the messagebus so would like to contribute #350

Open
wants to merge 332 commits into
base: exception-dbw
Choose a base branch
from

Conversation

amitsing89
Copy link

Hi,

I have started once to integrate the activeMq in the messagebus so i would like to add that to the repository, so if you can allow kme to contribute then it would be helpful to add a new component

sibiryakov and others added 30 commits November 1, 2017 17:49
hdr and redir persistence + cityhash64 + graceful shutdown fix + kafka SSL
imho, in hbase queue's `get_next_requests` method,  params: min_hosts and max_requests_per_host are optional, because this method will check whether they are None, eg line no.225 and no.236, but kwargs.pop will raise Exception if I don't give these two params.
the `from_worker` method is duplicate , base class `BaseCrawlingStrategy` define `from_worker` already.
Do not remove existing loggers on configuration
Add message type logging and time for batch
Improving errors logging in async offsets fetcher
update BCPerHostLimit in cluster example
Add Scrapy extension to export stats to Kafka
Use mixin class to create new db/sw classes
Extend messagebus class with stats logic
Extend codec logic with encoding/decoding stats
Use export-to-tsdb logic from bigbot-common package
Use single logic for forming SSL params
Move happybase to dependencies folder
Add get_stats() to distributed backend interface
Provide useful context manager to measure elapsed time
Use the manager to estimate get_stats() efficiency
@Gallaecio
Copy link
Member

@amitsing89 You should rebase your changes on top of the latest master as suggested. Have you used Git rebase before? Have you added the main repository as an upstream remote in your local clone of your fork?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.