Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the SHUB_APIURL and SHUB_STORAGE environment variables #177

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Support the SHUB_APIURL and SHUB_STORAGE environment variables #177

merged 3 commits into from
Dec 16, 2024

Conversation

Gallaecio
Copy link
Member

No description provided.

@Gallaecio
Copy link
Member Author

@elacuesta I am having a hard time figuring out why tests get a gzip-decoding issue on PyPy. I wonder if it is OK to merge stuff and release despite that or if we should look into it, e.g. maybe some dep upgrade is causing issues.

@Gallaecio
Copy link
Member Author

Oh, it’s vcrpy 6+ that broke that.

@Gallaecio Gallaecio merged commit 2fd8f21 into scrapinghub:master Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elacuesta elacuesta elacuesta approved these changes

@kmike kmike Awaiting requested review from kmike

@wRAR wRAR Awaiting requested review from wRAR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gallaecio @elacuesta