Fix running scripts with importlib installed. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
commented
Jul 5, 2024
| raise ValueError( | ||
| f"Script {script!r} not found in metadata at {dist._path!r}" | ||
| ) | ||
| script_filename = dist._path.joinpath(script) |
There was a problem hiding this comment.
I don't see a way to avoid accessing _path, though it's used only in the exception above and to get full file paths in tracebacks from the compiled code, which should be fine to truncate to just script as users won't access scripts on the Dash host anyway.
Gallaecio
approved these changes
Jul 5, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #82 caused by run_script missing in the importlib API. I tested this by deploying a project and running a script shipped by it, both with
zip_safe=Falseandzip_safe=True. Not sure if there are any other things that can be tested, I cannot test the error code path as Dash doesn't allow running non-existent scripts.