Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reqs for Scrapy 2.12.0. #198

Closed
wants to merge 1 commit into from

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Nov 18, 2024

Hello! We released Scrapy 2.12.0 so I've updated the reqs file, please let us know if any other changes are needed.

@kmike
Copy link
Member

kmike commented Nov 26, 2024

This needs scrapinghub/scrapinghub-entrypoint-scrapy#87 first, right?
Also, it seems it needs to be its own branch, not a merge to branch-2.11. Not sure how it's handled in PRs though.

@elacuesta
Copy link
Member

Thanks @wRAR! Regarding @kmike's comments:

This needs scrapinghub/scrapinghub-entrypoint-scrapy#87 first, right?

Yes indeed

Also, it seems it needs to be its own branch, not a merge to branch-2.11. Not sure how it's handled in PRs though.

Just a push of a new branch, in this case called branch-2.12. There CI build will create a 2.12-latest tag but the stack is not considered released until we (manually) push the 2.12 and 2.12-YYYYMMDD tags.

@elacuesta
Copy link
Member

I've taken this commit and pushed it to a new branch along with the update to the entrypoint package: https://github.com/scrapinghub/scrapinghub-stack-scrapy/tree/branch-2.12.
Closing this, thanks!

@elacuesta elacuesta closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants