url-matcher integration with scrapy-poet #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanprado
changed the base branch from
cacheable_provider
to
injector_record_replay_native
BurnzZ
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Hi @ivanprado , added some comments after a first pass. Looking good so far!
This was referenced Dec 10, 2021
BurnzZ
reviewed
Dec 20, 2021
tox.ini
Outdated
| @@ -7,7 +7,7 @@ deps = | |||
| pytest-cov | |||
| scrapy >= 2.1.0 | |||
| pytest-twisted | |||
| web-poet | |||
| web-poet @ git+https://[email protected]/scrapinghub/web-poet@handle_urls#egg=web-poet | |||
There was a problem hiding this comment.
Reminder to update this when scrapinghub/web-poet#16 is released.
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 95.96% 97.46% +1.50%
==========================================
Files 9 9
Lines 372 395 +23
==========================================
+ Hits 357 385 +28
+ Misses 15 10 -5
|
1 task
BurnzZ
force-pushed
the
url-matcher-integration
branch
from
54ea603 to
63029dc
Compare
BurnzZ
force-pushed
the
url-matcher-integration
branch
from
7e00bf6 to
17689b5
Compare
kmike
reviewed
May 18, 2022
kmike
reviewed
May 18, 2022
| BookPage: BPBookPage | ||
| }, | ||
| } | ||
| "SCRAPY_POET_OVERRIDES": [ |
There was a problem hiding this comment.
I wonder if we should provide an example with handle_urls decorator
There was a problem hiding this comment.
A good point! Added such an example in 0bc51b8.
kmike
approved these changes
May 18, 2022
There was a problem hiding this comment.
Thanks @BurnzZ, @ivanprado and @sortafreel!
I left a couple of minor comments; the PR looks good to me, +1 to merge.
BurnzZ
force-pushed
the
url-matcher-integration
branch
from
4374ad7 to
0bc51b8
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: this branch was created on top of #55. It should be merged only after the former one has been merged
New registry that uses the
url-matcherpatterns to configure the overrides. It is a backwards-incompatible change. See the updated documentation to get more context.A new release of web-poet is required because this depends on
scrapinghub/web-poet#16scrapinghub/web-poet#27TODO:
tox.iniandsetup-pyonce a new version is releasedOverrideRule,PageObjectRegistry, etc. using:ref:directive. But it requires introduce PageObjectRegistry with @hande_urls annotations web-poet#27 to be merged first.