w3lib-based url classes #46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## url-page-inputs #46 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 15 15
Lines 344 355 +11
=================================================
+ Hits 344 355 +11
|
kmike
commented
Jun 2, 2022
| def test_urljoin(): | ||
| url = _Url("http://example.com/foo/bar?x=y#fragment") | ||
| assert str(url.join("baz")) == "http://example.com/foo/baz" | ||
| assert str(url / "baz") == "http://example.com/foo/baz" |
There was a problem hiding this comment.
This is different from yarl, for the cases path doesn't end with "/": in yarl you need to call url.parent / "baz" to get urljoin behavior. I'm not sure what's better.
There was a problem hiding this comment.
+1 to the proposed behavior, clean and fit to web scraping scenarios.
kmike
commented
Jun 2, 2022
|
|
||
| def update_query(self: T_url, | ||
| new_parameters: Dict[str, str]) -> T_url: | ||
| new_url = add_or_replace_parameters(self._url, |
There was a problem hiding this comment.
yarl's update_query looks way more powerful than w3lib's add_or_replace_parameters, see https://yarl.readthedocs.io/en/latest/api.html#yarl.URL.update_query for the supported arguments. I like that multiple values are handled in yarl, and duplicate query parameters in general.
Gallaecio
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experiment: how a w3lib-based URL class could look like. Again, a minimal version.