-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tools configuration #101
Conversation
kmike
commented
Jul 12, 2023
- move to pyproject.toml when possible
- use pre-commit in tox, don't duplicate configuration
- don't run mypy in pre-commit
- update flake8, mypy and isort
- update github actions
* move to pyproject.toml when possible * use pre-commit in tox, don't duplicate configuration * don't run mypy in pre-commit * update flake8, mypy and isort * update github actions
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 9 9
Lines 647 647
=======================================
Hits 637 637
Misses 10 10 |
pyproject.toml
Outdated
multi_line_output = 3 | ||
|
||
[tool.mypy] | ||
#check_untyped_defs = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be addressed later on, or a leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be addressed later; should I remove it? The current config in scrapy-zyte-api doesn't use this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's used actually :) Let me fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was copying pre-commit/setup.cfg config options (and added no_warn_no_return = true just in case), but tox used a different config.