Cleanup tools configuration #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kmike
commented
Jul 12, 2023
kmike
commented
- move to pyproject.toml when possible
- use pre-commit in tox, don't duplicate configuration
- don't run mypy in pre-commit
- update flake8, mypy and isort
- update github actions
* move to pyproject.toml when possible * use pre-commit in tox, don't duplicate configuration * don't run mypy in pre-commit * update flake8, mypy and isort * update github actions
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 9 9
Lines 647 647
=======================================
Hits 637 637
Misses 10 10 |
Gallaecio
reviewed
Jul 12, 2023
pyproject.toml
Outdated
| multi_line_output = 3 | ||
|
|
||
| [tool.mypy] | ||
| #check_untyped_defs = true |
There was a problem hiding this comment.
To be addressed later on, or a leftover?
There was a problem hiding this comment.
To be addressed later; should I remove it? The current config in scrapy-zyte-api doesn't use this flag.
There was a problem hiding this comment.
Oh, it's used actually :) Let me fix it
There was a problem hiding this comment.
I was copying pre-commit/setup.cfg config options (and added no_warn_no_return = true just in case), but tox used a different config.
Gallaecio
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.