-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter mapping #151
Merged
Merged
Parameter mapping #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 98.83% 98.92% +0.08%
==========================================
Files 10 10
Lines 687 744 +57
==========================================
+ Hits 679 736 +57
Misses 8 8
|
wRAR
approved these changes
Nov 20, 2023
kmike
reviewed
Nov 28, 2023
kmike
reviewed
Nov 28, 2023
kmike
reviewed
Nov 28, 2023
kmike
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143.
_params.py
now contains a dictionary of top-level Zyte API request params with metadata about them, and it should be extended as new parameters are added upstream in the future. Related changes:"jobPosting"
is now recognized as an extraction type (affects whether or nothttpResponseBody
andhttpResponseHeaders
are enabled by default)."GET"
is now recognized as the default value of"httpRequestMethod"
, and stripped from request parameters if manually defined.*Options.extractFrom
is now taken into account to determine whether or not to keep the URL fragment. The fragment is no longer kept just because automatic extraction is used,browserHtml
must also be explicitly requested as extraction source."httpRequestBody"
and"httpRequestText"
values do not cause different fingerprints.sessionContext
,sessionContextParameters
,cookieManagement
,requestCookies
,responseCookies
.device
remains taken into account for fingerprinting (the default behavior for any unknown key). I am not completely sure, though. If it only affects requests (and not e.g. the viewport), maybe it would be best to ignore it during fingerprinting.httpResponseHeaders
(True/False), since we already take into account other outputs it can be combined with, in line howresponseCookies
is now ignored.To do: