Fail on SPM + transparent mode #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 98.89% 98.94% +0.04%
==========================================
Files 10 10
Lines 724 756 +32
==========================================
+ Hits 716 748 +32
Misses 8 8
|
wRAR
approved these changes
Nov 23, 2023
kmike
reviewed
Nov 23, 2023
scrapy_zyte_api/handler.py
Outdated
| @@ -62,6 +62,29 @@ def __init__( | |||
| raise NotConfigured( | |||
| "Zyte API is disabled. Set ZYTE_API_ENABLED to True to enable it." | |||
| ) | |||
| if settings.getbool("ZYTE_API_TRANSPARENT_MODE", False) and ( | |||
| settings.getbool("ZYTE_SMARTPROXY_ENABLED", False) | |||
There was a problem hiding this comment.
It's possible to disable SPM using spider attributes; how do we handle this case?
There was a problem hiding this comment.
What if we move this to a signal handler for spider_opened, where we can check the spider as well, and close the spider from there in this scenario?
There was a problem hiding this comment.
Sounds good. I think there is also a middleware method (is_enabled?) which can be useful, but I haven't really checked it.
BurnzZ
approved these changes
Nov 28, 2023
kmike
reviewed
Nov 29, 2023
kmike
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with raising
NotConfiguredfrom the handlers.However, I wonder if instead we should treat this as a fatal error and close the spider with a custom reason.
In fact, I wonder if we should do that for other
NotConfigurederrors in the handler, since some users have a hard time figuring out those kind of issues from the logs, and a non-working HTTP/HTTPS handler feels like a critical-enough issue to warrant closing the spider until it is addressed.