Count Zyte API requests from the downloader middleware itself #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
commented
Oct 22, 2024
| ) | ||
| total_requests = zapi_req_count + download_req_count | ||
| return total_requests >= self._max_requests | ||
| self.slot_request(request, spider, force=True) |
There was a problem hiding this comment.
Moved after the count to skip this part if the request is going to be ignored anyway.
kmike
approved these changes
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 97.86% 97.85% -0.01%
==========================================
Files 14 14
Lines 1590 1585 -5
Branches 294 293 -1
==========================================
- Hits 1556 1551 -5
Misses 14 14
Partials 20 20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.