Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for multiple data types extraction. #233

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add a test for multiple data types extraction. #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/mockserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,13 @@ def render_POST(self, request):
},
}

if request_data.get("productNavigation") is True:
response_data["productNavigation"] = {
"url": response_data["url"],
"name": "Product navigation",
"pageNumber": 0,
}

return json.dumps(response_data).encode()


Expand Down
55 changes: 55 additions & 0 deletions tests/test_providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
CustomAttributes,
CustomAttributesValues,
Product,
ProductNavigation,
)
from zyte_common_items.fields import auto_field

Expand Down Expand Up @@ -68,6 +69,13 @@ class ProductPage(BasePage):
product: Product


@attrs.define
class ProductNavigationPage(BasePage):
html: BrowserHtml
response: BrowserResponse
product_nav: ProductNavigation


class ZyteAPISpider(Spider):
url: str

Expand Down Expand Up @@ -1723,3 +1731,50 @@ def parse(self, response: DummyResponse, product: Product):

# Reset rules
default_registry.__init__() # type: ignore[misc]


class ZyteAPIMultipleSpider(Spider):
url: str

def start_requests(self):
yield Request(self.url, callback=self.parse_)

def parse_(
self,
response: DummyResponse,
page: ProductPage,
nav_page: ProductNavigationPage,
):
yield {
"html": page.html,
"response_html": page.response.html,
"product": page.product,
"productNavigation": nav_page.product_nav,
}


@ensureDeferred
async def test_multiple_types(mockserver):
settings = create_scrapy_settings()
settings["ZYTE_API_URL"] = mockserver.urljoin("/")
settings["SCRAPY_POET_PROVIDERS"] = {ZyteApiProvider: 0}
item, url, _ = await crawl_single_item(
ZyteAPIMultipleSpider, HtmlResource, settings
)
assert item["html"] == "<html><body>Hello<h1>World!</h1></body></html>"
assert item["response_html"] == "<html><body>Hello<h1>World!</h1></body></html>"
assert item["product"] == Product.from_dict(
dict(
url=url,
name="Product name",
price="10",
currency="USD",
)
)
assert item["productNavigation"] == ProductNavigation.from_dict(
dict(
url=url,
name="Product navigation",
pageNumber=0,
)
)
Loading