This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
feat(757): Pass disk annotation as toleration and node selector #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minzcmu
approved these changes
Sep 10, 2018
tkyi
reviewed
Sep 10, 2018
| const diskConfig = annotations[DISK_RESOURCE] || ''; | ||
| const nodeSelectors = diskConfig.toUpperCase() === 'HIGH' ? { disk: 'high' } : {}; | ||
|
|
||
| hoek.merge(nodeSelectors, this.nodeSelectors); |
There was a problem hiding this comment.
this.nodeSelectors will override nodeSelectors if there's any conflicts (https://github.com/hapijs/hoek/blob/master/API.md#mergetarget-source-isnulloverride-ismergearrays). Is this a concern at all?
There was a problem hiding this comment.
I believe it should be fine since we currently do not specify a default selector in regards to any resource.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently all Screwdriver V4 builds default to a predetermined amount of storage space. We want to offer users the option to configure higher disk space for their builds.
Objective
Pass the annotation
beta.screwdriver.cd/diskas a node selector/toleration. Nodes designated to support higher disk space per build will be labeled/tainted withdisk=high.References
screwdriver-cd/screwdriver#757