This repository has been archived by the owner on Apr 10, 2020. It is now read-only.
feat(757): Add disk label as a configurable option #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
approved these changes
Sep 12, 2018
minzcmu
suggested changes
Sep 12, 2018
config/default.yaml
Outdated
| @@ -53,6 +53,8 @@ executor: | |||
| # k8s node selectors for approprate pod scheduling | |||
| nodeSelectors: {} | |||
| preferredNodeSelectors: {} | |||
| labels: | |||
| disk: 'screwdriver.cd/disk' | |||
There was a problem hiding this comment.
Let's don't set the default, if we set the default and ppl with other cluster didn't configure their k8s cluster correctly. Then the pod will be pending forever if user specify a disk high annotation. We can leave it as empty and do a check in executor to do nothing if label is not configured here.
| @@ -91,6 +91,8 @@ executor: | |||
| preferredNodeSelectors: | |||
| __name: K8S_VM_PREFERRED_NODE_SELECTORS | |||
| __format: json | |||
| labels: | |||
| disk: K8S_DISK_LABEL | |||
There was a problem hiding this comment.
Can we add disk under resources?
something like
resources:
disk:
high: K8S_DISK_LABEL
minzcmu
approved these changes
Sep 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
executor-k8s-vm will consume the value of
options.kubernetes.resources.disk.highand use it to set the toleration/node affinity of pods that require a high disk resource.Objective
Add
options.kubernetes.resources.disk.highas a configurable option.References
screwdriver-cd/executor-k8s-vm#42
screwdriver-cd/screwdriver#757