Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid modifying sys.path #123

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Avoid modifying sys.path #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db047e
remove modification of sys.path
shashank-iitbhu Mar 24, 2024
8a37f35
remove unnecessary imports
shashank-iitbhu Mar 24, 2024
87651d2
merge from upstream
shashank-iitbhu Mar 24, 2024
4954e17
ruff check
shashank-iitbhu Mar 24, 2024
272b77c
#122 update docs with directions to pip install the local version
andrewtavis Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ After activating the virtual environment, install the required dependencies by r
```bash
pip install --upgrade pip # make sure that pip is at the latest version
pip install -r requirements.txt # install dependencies
pip install -e . # install the local version of Scribe-Data
```

> [!NOTE]
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ After activating the virtual environment, install the required dependencies by r
```bash
pip install --upgrade pip # make sure that pip is at the latest version
pip install -r requirements.txt # install dependencies
pip install -e . # install the local version of Scribe-Data
```

> [!NOTE]
Expand Down
1 change: 1 addition & 0 deletions docs/source/_static/CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ GitHub also has documentation on how to `Generate a new SSH key <https://docs.gi
python3 -m venv venv # make an environment venv
pip install --upgrade pip # make sure that pip is at the latest version
pip install -r requirements.txt # install dependencies
pip install -e . # install the local version of Scribe-Data

..

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/English/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/English/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/English/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/French/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/French/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/French/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/German/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/German/prepositions/format_prepositions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/German/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/German/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Italian/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/Italian/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Italian/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Portuguese/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/Portuguese/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Portuguese/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Russian/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Russian/prepositions/format_prepositions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/Russian/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Russian/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Spanish/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/Spanish/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Spanish/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Swedish/nouns/format_nouns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
export_formatted_data,
load_queried_data,
map_genders,
Expand Down
7 changes: 1 addition & 6 deletions src/scribe_data/extract_transform/languages/Swedish/translations/translate_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@

import json
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.extract_transform.translation.translation_utils import ( # noqa: E402
from scribe_data.extract_transform.translation.translation_utils import (
translate_to_other_languages,
)

Expand Down
6 changes: 1 addition & 5 deletions src/scribe_data/extract_transform/languages/Swedish/verbs/format_verbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
import os
import sys

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import export_formatted_data, load_queried_data # noqa: E402
from scribe_data.utils import export_formatted_data, load_queried_data

file_path = sys.argv[0]

Expand Down
8 changes: 1 addition & 7 deletions src/scribe_data/extract_transform/translation/translation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,11 @@
"""

import json
import os
import signal
import sys

from transformers import M2M100ForConditionalGeneration, M2M100Tokenizer

PATH_TO_SCRIBE_ORG = os.path.dirname(sys.path[0]).split("Scribe-Data")[0]
PATH_TO_SCRIBE_DATA_SRC = f"{PATH_TO_SCRIBE_ORG}Scribe-Data/src"
sys.path.insert(0, PATH_TO_SCRIBE_DATA_SRC)

from scribe_data.utils import ( # noqa: E402
from scribe_data.utils import (
get_language_dir_path,
get_language_iso,
get_target_langcodes,
Expand Down
Loading
Loading