Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand verb query for Arabic data #127

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

mrbazzan
Copy link
Contributor

@mrbazzan mrbazzan commented Apr 3, 2024

Based on Wikidata, Arabic Verbs are divided into three (which are further divided into):

  • Past: Performative Passive and Performative Active
  • Present (Fi'il mudari'): Indicative Present, Subjunctive Present, Jussive Present
  • Imperative

These are just my assumptions though.

I added queries for a tense in each category. Am I on the right track?

By the way, is it possible to add a feature to the
Wikidata Query Service so that some part of a query can be collapsed?
This is so that there isn't constant scrolling between the editor and the result
tab below (if some of the queries are collapsed, everything can appear on the
screen at the same time).

Copy link

github-actions bot commented Apr 3, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review April 3, 2024 20:34
@andrewtavis
Copy link
Member

I added queries for a tense in each category. Am I on the right track?

Is looking good to me, @mrbazzan!

By the way, is it possible to add a feature to the
Wikidata Query Service so that some part of a query can be collapsed?
This is so that there isn't constant scrolling between the editor and the result
tab below (if some of the queries are collapsed, everything can appear on the
screen at the same time).

The Wikidata Query Service UI doesn't offer this feature, which is why I normally am always writing my SPARQL queries in VS Code. There are a couple of good extensions that you can install to make it all go a bit easier, which you can see at the top of the environment setup section of the readme.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brining this in regardless of the fail as there are no changes to the environment and the error is a network timeout. Thanks for this, @mrbazzan! Looking forward to the next queries! We'd definitely welcome work like this for nouns, verbs, etc for any language you'd feel like sending along :)

Let us know if you need further assistance with this 😊

@andrewtavis andrewtavis merged commit a0a2ca6 into scribe-org:main Apr 8, 2024
1 of 2 checks passed
@mrbazzan
Copy link
Contributor Author

The Wikidata Query Service UI doesn't offer this feature, which is why I normally am always writing my SPARQL queries in VS Code.

:(

There are a couple of good extensions that you can install to make it all go a bit easier, which you can see at the top of the environment setup section of the readme.

Thanks. The QID extension looks nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants