-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature pre-commit #141
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
.pre-commit-config.yaml
Outdated
args: [--fix, --exit-non-zero-on-fix] | ||
- id: ruff-format | ||
|
||
# - repo: https://github.com/pre-commit/mirrors-prettier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this commented out Prettier code here, @kush34 :) We're not using it in Scribe-Data.
No stress on the Mac OS build, btw @kush34 :) We have some problems with those right now. Generally this all looks good! The JSON files that have all of these changes are going to be moved out of Scribe-Data at some point anyway. Do you want to mark it as ready for review? |
Feel free to send along another commit to remove the commented out code that I mentioned here, but aside from that it should be fine :) |
I'm going through and trying to close things now, @kush34, so will actually mark as ready and bring it in :) Hope that's ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up, @kush34! Appreciate the quick work here. Really excited to have this in the project now!
Contributor checklist
Description
Added Pre-commit feature: This feature runs our hooks on every commit to automatically point out issues in code such as missing semicolons, trailing whitespace, and debug statements. Pointing these issues out before code review makes the process easier.
Related issue