-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to convert file inputs to either json, csv or tsv. #338
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Great work @john-thuo1 ✨
Thanks for the review @mhmohona ! I will proceed to look into the remaining tests for the functions then, |
Yes that'd be great, @john-thuo1! I'll review once those are in :) |
Checking in here, @john-thuo1 :) Do you want to do the tests in a separate PR, or continue on this one? Whatever would be best for you 😊 |
I had some challenges figuring out how to mock the input file, output directory, and output file and patching some functionalities, hence the delay, but it is all good now! I have finished the tests. You can go ahead with the review @andrewtavis and let me know of other test scenarios I can add. |
Contributor Checklist
Description
This pull request adds functionality to convert data into CSV, TSV, and JSON formats. The changes include:
convert_to_json
andconvert_to_csv_or_tsv
functions inconvert.py
.main.py
to support new conversion commands.get
function to support different file formats other that JSON.Example Commands:
Tests for the convert methods have been implemented in
test_convert.py
Related issue
convert
fromget
in Scribe-Data CLI #213