Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_adverbs.sparql #362

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

Otom-obhazi
Copy link
Contributor

for adverb

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Otom-obhazi Otom-obhazi mentioned this pull request Oct 15, 2024
8 tasks
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 15, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further edits are needed on this one here, @Otom-obhazi :) Well done!

@andrewtavis andrewtavis merged commit d628ec7 into scribe-org:main Oct 15, 2024
1 check passed
@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 15, 2024 via email

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member

Thanks for this @Otom-obhazi. Let me stress here as well, please make sure to get all of the forms when you're making the queries as that's a more full contribution to the project. If we need to go back and edit the queries afterwards, then it's adding more work potentially.

@Otom-obhazi
Copy link
Contributor Author

@andrewtavis please what forms??

@andrewtavis
Copy link
Member

In one of your adverb queries put ?lexeme as the first thing returned and you'll see a list of Wikidata item URIs - at least if the query returns things. With these queries we also want the forms of the word, which you can see by clicking on the URI and going to the item's page. When there scroll to the bottom for the forms. Not every one of the languages is going to have distinct forms for adverbs, but some might. Forms are things like the conjugations of a verb or the plural of a noun. Not only do we want to return the word itself, but we also want to return its forms - i.e. all the other data about the word.

Investigate some of the larger queries and investigate the URIs via returning ?lexeme from the query as well. Then you can check your queries and make sure that the forms are included. Specifically for Slovak there are forms that weren't included :) Try to make a new version of that one that functions like the other, larger queries.

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 16, 2024 via email

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 17, 2024 via email

@andrewtavis
Copy link
Member

Forms are just a way of talking about data on an item in Wikidata. If the item is a verb, then a form is a conjugation or something like this, whereas if it's a noun it could be its plural or gender.

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 17, 2024 via email

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 17, 2024 via email

@andrewtavis
Copy link
Member

Feel free to look into queries in the newly opened issues :)

@andrewtavis
Copy link
Member

Write in then and I can assign, and let us know which queries you want to work on 😊

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants