Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latin adverbs & prepositions query #414

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 18, 2024

Contributor checklist


Description

Added query for Latin adverbs & prepositions query

Related issue

Copy link

github-actions bot commented Oct 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
@andrewtavis andrewtavis self-requested a review October 18, 2024 10:26
@andrewtavis
Copy link
Member

Hi @axif0 👋 These queries currently returns no forms even though there are forms on the lexemes available. Can you please reference the new SPARQL query writing docs and make the needed changes to get all the forms? Thank you :)

@axif0
Copy link
Contributor Author

axif0 commented Oct 20, 2024

@andrewtavis For Latin preposition, I found the Grammatical features are Possitive, ablative, accusative. How can we write the query?

AIso, found that-
No query was returned in finnish preposition , tajik, tamil, and yoruba. As the wikidata doesn't has the language data for preposition thats why we don't get the query returns?

Also, in Estonian and Slovak case column is empty.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your observations I removed the cases from prepositions, @axif0 :) Thanks for this! Check the changes to the queries I made to see how to get the forms you found. Happy to support you on this as you haven't been writing many queries, but also check the SPARQL query writing doc as mentioned as that hopefully will help!

And re: no data returned, you're absolutely correct, Wikidata has no data in these cases, but it will at some point hopefully 😊

@andrewtavis andrewtavis merged commit ee2ec76 into scribe-org:main Oct 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants