Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Norwegian/Bokmal verb query #429

Closed
wants to merge 2 commits into from

Conversation

VNW22
Copy link
Contributor

@VNW22 VNW22 commented Oct 18, 2024

Contributor checklist


Description

This query expands the norwegian/Bokmal verbs query including all the forms. The queries have been tested at query.wikidata.org

Related issue

  • #ISSUE_NUMBER

Copy link

github-actions bot commented Oct 18, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
@andrewtavis andrewtavis self-requested a review October 18, 2024 19:25
@andrewtavis
Copy link
Member

Can we get the properties expanded out a bit here, @VNW22? I think that the data needs to be modeled a bit better by the Wikidata community as some forms have the exact properties but are different. With that being said, expanding the properties to the fullest will prepare us for when that remodel happens.

@VNW22
Copy link
Contributor Author

VNW22 commented Oct 19, 2024

Absolutely, that makes sense. I’ll work on expanding the properties as much as possible to ensure we’re capturing all potential forms.

@VNW22 VNW22 closed this Oct 21, 2024
@VNW22 VNW22 deleted the Expand-Bokmål-verbs-query branch October 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants