Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian adjectives and their common forms #442

Merged

Conversation

OmarAI2003
Copy link
Contributor

Contributor checklist


Description

This PR adds a SPARQL file to extract Russian adjectives. Currently, the Russian directory supports extracting nouns, verbs, adverbs, prepositions, emoji_keywords and now and adjectives.

Copy link

github-actions bot commented Oct 20, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@OmarAI2003 OmarAI2003 changed the title Russian adjectives their common forms Russian adjectives and their common forms Oct 20, 2024
@OmarAI2003
Copy link
Contributor Author

I made sure to incorporate the feedback you provided in the last PR.let me know if there's anything that needs improvement.

@andrewtavis
Copy link
Member

There still seem to be a lot of forms that are not included here, @OmarAI2003. Do you want to add them in, or should I look into it?

@OmarAI2003
Copy link
Contributor Author

No, I can add them, but how many more forms do you think this file can accommodate?

@andrewtavis
Copy link
Member

We can split the file if need be later, @OmarAI2003. Thanks!

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 20, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting two entries per adjective, but this is fine for now, @OmarAI2003 :) Hopefully we'll write a test at some point that will help us derive what's up here 😊

@andrewtavis andrewtavis merged commit 6640ea4 into scribe-org:main Oct 20, 2024
3 of 5 checks passed
@OmarAI2003 OmarAI2003 deleted the Russian_adjectives_their_forms branch October 24, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants