-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Russian adjectives and their common forms #442
Russian adjectives and their common forms #442
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
I made sure to incorporate the feedback you provided in the last PR.let me know if there's anything that needs improvement. |
There still seem to be a lot of forms that are not included here, @OmarAI2003. Do you want to add them in, or should I look into it? |
No, I can add them, but how many more forms do you think this file can accommodate? |
We can split the file if need be later, @OmarAI2003. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting two entries per adjective, but this is fine for now, @OmarAI2003 :) Hopefully we'll write a test at some point that will help us derive what's up here 😊
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR adds a SPARQL file to extract Russian adjectives. Currently, the Russian directory supports extracting nouns, verbs, adverbs, prepositions, emoji_keywords and now and adjectives.