Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cli list tests output check #447

Merged

Conversation

OmarAI2003
Copy link
Contributor

Contributor checklist


Description:

This issue addresses the need to improve the list_languages and list_languages_for_data_type functions in the CLI. The following changes was implemented:

  1. Dynamic Spacing: Modify both functions to use dynamic column widths for displaying languages, ISO codes, and QIDs, ensuring proper alignment regardless of the data.

  2. Improved Unit Tests: Update the unit tests to:

    • Verify that the headers are formatted dynamically based on the current language metadata.
    • Validate the first language entry in the output.
    • Ensure the total number of print calls corresponds accurately to the expected output.

Related issue

…ynamic spacing and improved test coverage

- Implement dynamic spacing for language, ISO, and QID columns in both functions.
- Update unit tests to verify header formatting and first language entry dynamically for each function.
- Enhance total print call count validation to ensure accuracy.
Copy link

github-actions bot commented Oct 20, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 21, 2024 11:11
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2024
@OmarAI2003
Copy link
Contributor Author

Once #472 is merged, this PR will require additional commits to incorporate the new formatting updates in the CLI list file. @andrewtavis

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing these, @OmarAI2003! Glad to not have to update this all the time :)

@andrewtavis andrewtavis merged commit 8620582 into scribe-org:main Oct 23, 2024
6 checks passed
@OmarAI2003 OmarAI2003 deleted the simplify-cli-tests-output-check branch October 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants