Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#450 Script and workflow created for query form check #451

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

andrewtavis
Copy link
Member

@andrewtavis andrewtavis commented Oct 21, 2024

Contributor checklist


Description

Note: This is WIP

The number of queries is getting to a point where we need to have a workflow to make sure they're still high quality and returning what they should be. This PR adds in check_query_forms.py, lexeme_form_metadata.json and the corresponding GitHub workflow to do just this :)

Related issue

Copy link

github-actions bot commented Oct 21, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2024
@andrewtavis andrewtavis merged commit 003323d into main Oct 21, 2024
6 checks passed
@andrewtavis andrewtavis deleted the 450-form-check-workflow branch October 21, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant