Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian query nouns, adjectives, adverbs #452

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

catreedle
Copy link
Contributor

Contributor checklist


Description

This PR introduces query_nouns.sparql and query_adjectives.sparql to retrieve Persian nouns and adjectives.
Nouns include:

  • singular
  • plural

Adjedtives include:

  • adjectives
  • singular
  • plural

Queries have been tested on https://query.wikidata.org/

Related issue

Copy link

github-actions bot commented Oct 21, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@catreedle catreedle changed the title Persian query Persian query nouns and adjectives Oct 21, 2024
@catreedle catreedle changed the title Persian query nouns and adjectives Persian query nouns, adjectives, adverbs Oct 21, 2024
@andrewtavis andrewtavis self-requested a review October 21, 2024 11:13
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 21, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @catreedle! All's working great, and just some minor formatting. Maybe check the changes I made so you can keep an eye out for it next time :)

@andrewtavis andrewtavis merged commit 54b060c into scribe-org:main Oct 22, 2024
6 checks passed
@catreedle
Copy link
Contributor Author

Thanks for this, @catreedle! All's working great, and just some minor formatting. Maybe check the changes I made so you can keep an eye out for it next time :)

thank you!

@catreedle catreedle deleted the persian-query branch October 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants