Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish queries #457

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Polish queries #457

merged 3 commits into from
Oct 24, 2024

Conversation

Nowshin1077
Copy link
Contributor

Added adjective, adverb and preposition queries

Contributor checklist


Description

Related issue

Added adjective, adverb and preposition queries
Copy link

github-actions bot commented Oct 21, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Can you add the line to get just the lexeme ID instead of the full lexeme URI to these queries, @Nowshin1077? You can see it in the other queries. And would you be able to remove all inline comments. The queries are simple enough that the query doctoring at the top should handle this :)

@andrewtavis
Copy link
Member

Could you add optional selections of singular and plural forms to this query, @Nowshin1077? :)

@Nowshin1077
Copy link
Contributor Author

@andrewtavis Sure, I am working on it 😊

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 24, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will bring this in and we can work further on this in a future issue, @Nowshin1077 :) Trying to clear the PRs and current issues 😊

@andrewtavis andrewtavis merged commit a4eb0fc into scribe-org:main Oct 24, 2024
7 checks passed
@andrewtavis andrewtavis mentioned this pull request Oct 24, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants