Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#188 #194 autocomplete bug fix and autosuggest placeholders #203

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

andrewtavis
Copy link
Member

@andrewtavis andrewtavis commented Sep 4, 2022

Alright, @SaurabhJamadagni, this is a lot more minor improvements to fix the bug where autocomplete wasn't being triggered after a command was used. I got carried away a bit again though 😊

What's included:

  • The aforementioned bugfix
  • Added an emum AutoActionState that determines if we're completing or suggesting
    • I made a boolean at first and was like, "Waaaaaait a minute..... 😅"
  • Fixed the sorting of the words for autocomplete so that it's done regardless of case
  • Fixed the conditionals within autocomplete as we need to be able to type a lowercase word but get an uppercase/caps suggestion such as germany -> Germany
  • Added variables for the first three words that appear whenever you load a system version of one of the Scribe languages that can serve as our default autosuggestions (replaced your function with them as you directed)
  • Set up a trigger within conditionallySetAutoActionBtns to determine which kind of action is being done
  • Went through and defined what type of action should follow each kind of key press (spaces -> autosuggest, normal keys -> autocomplete, etc)

Let me know what you think on all this! Just am trying to get the work load down a bit for the both of us. Would be great if you could check out the last bugs in #188 related to deletion :) After that it's on to autosuggest 😊

Copy link
Collaborator

@SaurabhJamadagni SaurabhJamadagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrewtavis! The changes look great! That was a good dodge with the enum. Do not wish to spiral into booleans again haha. Thanks for requesting a review. Learned a few tricks by looking at the way you refactor code and use closures and navigate the codebase. Thanks 😊

@SaurabhJamadagni
Copy link
Collaborator

Would be great if you could check out the last bugs in #188 related to deletion :) After that it's on to autosuggest

Yes absolutely! On it 😊

@andrewtavis andrewtavis merged commit f7271ff into main Sep 5, 2022
@andrewtavis andrewtavis deleted the feature-188-bugfix branch September 5, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants