Made separate functions for key width and key padding, and adjusted t… #389
Conversation
…he layout of the expanded keyboard. Issue scribe-org#362
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. It'd be great to have you! Maintainer checklist
|
| @@ -26,7 +26,7 @@ var keyWidth = CGFloat(0) | |||
| var letterKeyWidth = CGFloat(0) | |||
| var numSymKeyWidth = CGFloat(0) | |||
| var isFirstKeyboardLoad = false | |||
|
|
|||
| var disableAccentCharacters = false; | |||
There was a problem hiding this comment.
Oh interesting.. 🤔 just learned that semicolons are also optional in Swift 😲
Not 100% on how y'all have been doing this, but we use SwiftLint for linting? Do we enforce linting?
Total nit hehe - the above trailing semicolon simply caught my eye, and led me to searching a bit about SwiftLint 😆 Appears like the community seems to prefer removing trailing semicolons? Not sure, but made me think about linting for us.
NOTE: no need to set any of this up in this PR 😆 just commenting as something for us to think through 👍
There was a problem hiding this comment.
Ya I'd say we don't need the semicolons as well, thanks @wkyoshida! Maybe we can get ourselves one of them fancy PR linting checks 🤠 Should we make an issue for it?
Removed trailing semicolon
| widthAnchor.constraint(equalToConstant: numSymKeyWidth * 1).isActive = true | ||
| } else if ["delete", "#+=", "selectKeyboard", SpecialKeys.capsLock].contains(key) { | ||
| layer.setValue(true, forKey: "isSpecial") | ||
| widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarSpecialKeysWidth).isActive = true //*2 scalarSpecialKeysWidth = 1 |
There was a problem hiding this comment.
We need a space between the slashes and the comment
There was a problem hiding this comment.
I'll go through and add in the minor nitpick edit to the comment, @henrikth93 :) Thanks so much for the work here! 🥳 Let's discuss what else is needed for the main issue in the sync, but I'll close #383 once I'm done with the minor edits for this 😊
…he layout of the expanded keyboard.
Issue #362 (This needs to be implemented for more languages, if needed)
Contributor checklist
Description
Related issue