This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
fix: Update-Dockerfile #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
Signed-off-by: Lavish Gupta <[email protected]>
eram
approved these changes
Oct 9, 2024
Dockerfile
Outdated
| @@ -83,20 +83,17 @@ RUN --mount=type=secret,id=GEOIPUPDATE_ACCOUNT_ID \ | |||
| /bin/sh -c "/usr/bin/entry.sh || echo 'Failed to get GeoIP database, disabling'; exit 0" | |||
|
|
|||
| # Stage 5: Python dependencies | |||
| FROM docker.io/python:3.12.2-slim-bookworm AS python-deps | |||
| FROM cgr.dev/chainguard/wolfi-base AS python-deps | |||
There was a problem hiding this comment.
why did you change the python-deps section? I think it's enough to change 'final-image' secton.
Dockerfile
Outdated
| apt-get install -y --no-install-recommends runit && \ | ||
| apt-get clean && \ | ||
| rm -rf /tmp/* /var/lib/apt/lists/* /var/tmp/ && \ | ||
| RUN apk add --no-cache python3=${PYTHON_VERSION} py3-pip libpq openssl xmlsec libmaxminddb ca-certificates runit && \ |
There was a problem hiding this comment.
missing apk update
do we need those: py3-pip libqp ?
missing: libqp5 libxmlsec1-openssl libmaxminddb0 ??
missng: apk cache clean - - -and maybe also rm on the folder of the cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)