Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hlint sources #100

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Hlint sources #100

merged 1 commit into from
Sep 29, 2023

Conversation

jsynacek
Copy link
Contributor

No description provided.

@jsynacek jsynacek requested a review from arybczak June 14, 2023 12:19
@arybczak
Copy link
Collaborator

Looks good, but please add accompanying CI check.

@jsynacek jsynacek force-pushed the jsynacek-hlint branch 5 times, most recently from 3e89d6c to c8a02b5 Compare August 29, 2023 07:29
# v2.4.6
- uses: haskell/actions/hlint-setup@a99601b177e00b98c78b6f6de680a101cf1c619d
with:
version: 3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the latest version instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do the latest.

@jsynacek
Copy link
Contributor Author

Looks good, but please add accompanying CI check.

Done.

Copy link
Collaborator

@arybczak arybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge after rebasing and checking that it passes on the current master :)

# v2.4.6
- uses: haskell/actions/hlint-setup@a99601b177e00b98c78b6f6de680a101cf1c619d
with:
version: 3.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do the latest.

@jsynacek jsynacek merged commit fd1ae0e into master Sep 29, 2023
7 checks passed
@jsynacek jsynacek deleted the jsynacek-hlint branch September 29, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants