Add the possibility to set the maximum number of headers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanjouty
approved these changes
May 15, 2024
| @@ -110,7 +110,6 @@ import qualified Data.Aeson as A | |||
|
|
|||
| import qualified Data.Traversable as T | |||
| import Control.Exception (throw, throwIO, Exception) | |||
| import Data.Monoid | |||
There was a problem hiding this comment.
Irrelevant change, we should probably remove this especially if we want to upstream our changes?
|
|
||
| -- | The maximum number of header lines. | ||
| -- | ||
| -- @since TODO |
There was a problem hiding this comment.
We would need to fix these TODO documentation comments before submitting a PR upstream
|
Right, I had to manually enable actions as this is a forked repository and it could steal something from the Scrive org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kontrakcja PR https://github.com/scrive/kontrakcja/pull/7076