Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace zstd-related symbol to avoid duplication #22

Merged
merged 11 commits into from
Aug 2, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 27, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@omerfirmak
Copy link

omerfirmak commented Jul 29, 2024

shouldn't we also add scroll_ prefix to points in the code where we are calling zstd functions?

@colinlyguo
Copy link
Member Author

shouldn't we also add scroll_ prefix to points in the code where we are calling zstd functions?

we only call C.compress_scroll_batch_bytes, the function name already has a scroll. btw, what's the rationale behind adding scroll_ to compress_scroll_batch_bytes?

@colinlyguo colinlyguo requested a review from noel2004 July 30, 2024 03:44
@0xmountaintop 0xmountaintop merged commit e99a0c8 into main Aug 2, 2024
3 checks passed
@colinlyguo colinlyguo deleted the sync-upstream branch August 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants