[feat] Domain spec poseidon hash #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
reviewed
Jul 19, 2023
| @@ -175,3 +175,8 @@ func HashFixed(inpBI []*big.Int) (*big.Int, error) { | |||
| rE.ToBigIntRegular(r) | |||
| return r, nil | |||
| } | |||
|
|
|||
| // Deprecated HashFixed entry, with domain field is 0 | |||
| func HashFixed(inpBI []*big.Int) (*big.Int, error) { | |||
There was a problem hiding this comment.
print out a warning message that this function is deprecated.
icemelon
approved these changes
Jul 22, 2023
|
change has been included in #403 so this can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
HashFixedWithDomainentry incrypto/poseidon/poseidon.go. This method enabli caller specifying a domain field in the 2->1 poseidon hash and it would be used by the new zktrie module with updated hash scheme