feat: robust deployment script #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiweichi
force-pushed
the
feat-robust-deployment
branch
from
a80fc69
to
591b875
Compare
dghelm
approved these changes
Jul 25, 2024
|
|
||
| ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).addSequencer(L1_COMMIT_SENDER_ADDR); | ||
| ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).addProver(L1_FINALIZE_SENDER_ADDR); | ||
| if (!ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).isSequencer(L1_COMMIT_SENDER_ADDR)) { |
There was a problem hiding this comment.
Follow-up: We should consider logging existing Sequencers and Provers if this function adds new ones and there is already one defined. This could be a risky security oversight if people re-run a script not realizing they've enabled multiple commit senders.
There was a problem hiding this comment.
Sequencers in contract are saving in a mapping, this makes it hard to log existing sequencers.
We can try to save all sequencers address in a local file, but this seems don't prevent people add sequencers in another environment different from the local file.
| if (!ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).isSequencer(L1_COMMIT_SENDER_ADDR)) { | ||
| ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).addSequencer(L1_COMMIT_SENDER_ADDR); | ||
| } | ||
| if (!ScrollChain(L1_SCROLL_CHAIN_PROXY_ADDR).isProver(L1_FINALIZE_SENDER_ADDR)) { |
|
Let's merge this branch since this feature required urgently. And follow up logging existing Sequencers and Provers in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The deployment script is not reliable with a public endpoint, due to gas price spike and other errors.
Solution:
To address this, we enable resume when deployment fails. Basically there are four types of transactions:
BTW, although seems the problem only happens in L1, still we no sure if there are potential problem in L2, besides we deploy both L1/L2 in one shell script now. If we think it's redundant, we can revert commit "feat: l2 robust deployment script".