fix address of L1ScrollMessenger and gasLimit for L1->L2 bridging #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zzq0826
previously approved these changes
Dec 13, 2023
zzq0826
approved these changes
Dec 13, 2023
zimpha
added a commit
that referenced
this pull request
Dec 18, 2023
zzq0826
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issues
closes #144
Description
L1ScrollMessengeris incorrect in a few docs.gasLimitshould not be5000. It is not enough. Changing to1000000should be better.Changes
0xBa50f5340FB9F3Bd074bD638c9BE13eCB36E603dto0x781e90f1c8Fc4611c9b7497C3B47F99Ef6969CbC5000to1000000.