Curie upgrade updates #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
roylou
approved these changes
Jun 18, 2024
Thegaram
approved these changes
Jun 18, 2024
colinlyguo
reviewed
Jun 18, 2024
isabellewei
added a commit
that referenced
this pull request
Jul 5, 2024
* Curie updates (#271) * curie-update-libzkp-version * security nit * move contact info into highlight * change Aside type * Update running-a-scroll-node.mdx (#278) * nodeKey hashing are done with domain 512 not 256 Am currently making a storage prover in noir and found this error In the zktrie repo nodekeys are hashed with ToSecureKey() in type/util.go (afaik) https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/util.go#L107 ToSecureKey() uses Hash() in types/bytes32.go which uses HASH_DOMAIN_BYTE32 as domain which is 256 *2 (512) see here: https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/hash.go#L16 and here is where i did my test in noir :D (account leaf is lower in same file) https://github.com/jimjimvalkema/scrollZkStorageProofs/blob/bcdd922405e046e99787b8b47f374befac170779/ScrollStorageProver/src/main.nr#L168 * add get in touch button * Revert "add get in touch button" This reverts commit 5c695f2. * Curie update details (#286) * remove legacy flag for foundry * update Curie details * fix typo * oops * Add PR descriptions --------- Co-authored-by: colinlyguo <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: Sina Pilehchiha <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: jimjimvalkema <[email protected]> Co-authored-by: Daniel Helm <[email protected]> Co-authored-by: zhengqi zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the
scroll-upgradesandrolluppages