Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curie updates #289

Merged
merged 13 commits into from
Jul 5, 2024
Merged

Curie updates #289

merged 13 commits into from
Jul 5, 2024

Commits on Jun 18, 2024

  1. Curie updates (#271)

    @isabellewei
    isabellewei committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    07d1f80 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. curie-update-libzkp-version

    @colinlyguo
    colinlyguo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    40c2df2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #276 from scroll-tech/curie-upgrade-update-circuit… 

    …-version

Curie: update libzkp version to v0.11.3
    @colinlyguo
    colinlyguo committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7dc2fbe View commit details
    Browse the repository at this point in the history

  3. security nit

    @isabellewei
    isabellewei committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    eaa7858 View commit details
    Browse the repository at this point in the history

  4. move contact info into highlight

    @isabellewei
    isabellewei committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    403edec View commit details
    Browse the repository at this point in the history

  5. change Aside type

    @isabellewei
    isabellewei committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2055873 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge pull request #277 from scroll-tech/isabellewei/security 

    Small change to Audits page
    @spilehchiha
    spilehchiha committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    84689dd View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Update running-a-scroll-node.mdx (#278)

    @Thegaram
    Thegaram committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e064a7b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. nodeKey hashing are done with domain 512 not 256 

    Am currently making a storage prover in noir and found this error

In the zktrie repo nodekeys are hashed with ToSecureKey() in type/util.go (afaik)
https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/util.go#L107

ToSecureKey() uses Hash()  in types/bytes32.go which uses HASH_DOMAIN_BYTE32 as domain which is 256 *2 (512)
see here: https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/hash.go#L16

and here is where i did my test in noir :D (account leaf is lower in same file)
https://github.com/jimjimvalkema/scrollZkStorageProofs/blob/bcdd922405e046e99787b8b47f374befac170779/ScrollStorageProver/src/main.nr#L168
    @jimjimvalkema
    jimjimvalkema committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3930a4c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge pull request #282 from jimjimvalkema/patch-1 

    fix page zktrie: change the domain of nodeKey hashing to 512 instead of 256
    @dghelm
    dghelm committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    8e81ea8 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. add get in touch button

    @zzq0826
    zzq0826 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5c695f2 View commit details
    Browse the repository at this point in the history

  2. Revert "add get in touch button" 

    This reverts commit 5c695f2.
    @zzq0826
    zzq0826 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    94cfcdd View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Curie update details (#286) 

    * remove legacy flag for foundry

* update Curie details

* fix typo

* oops

* Add PR descriptions
    @isabellewei
    isabellewei committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    25a4e04 View commit details
    Browse the repository at this point in the history