Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to prod #349

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Merge to prod #349

merged 8 commits into from
Oct 10, 2024

Conversation

isabellewei
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 33d50db
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/66fb7a8e4c4ac90008157d8e
😎 Deploy Preview https://deploy-preview-349.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@isabellewei isabellewei merged commit c83d916 into prod Oct 10, 2024
6 checks passed
isabellewei added a commit that referenced this pull request Jan 9, 2025
* feat: Add turkish transalation (build fix) (#256) (#257)

* lang "tr" added, sections "getting-started" and "user-guide" is translated accordingly

* Update overview.md

* technology/bridge turkish translations are added

* lang[tr] user-guide finalized

* learn added, getting started improvements

* /learn and most of the /technology is translated to lang[tr]

* /technology/chain finished

* /developers section translations to lang[tr]

* /developers developer-quickstart and transaction-fees-on-scroll translated to lang[tr]

* /developers section finished except guides part. some other language correctments in lang[tr]

* execution-node-tr completed

* rollup-node-tr completed

* /developers/guides is completed

* added lang[tr] for welcome page frontend

* cross-domain-messaging-tr completed

* deposit-gateways-tr completed

* withdraw-gateways-tr completed

* minor improvements

* visual bugs fixed in kzg schemes lang[tr]

* minor improvements

* general language improvements and word suffix correctments lang[tr]

* translation completions of some overlooked technical terms lang[tr]

* minor fix

* term improvements

* minor improvements in terms

* minor punctuation suffix correction

* minor punctuation suffix fixes

* more minor improvements

* minor update

* zktrie.mdx güncelleme

* refactor

* /technology/sequencer/zktrie.mdx translation completed

* refactor

* mini typo in kzg schemes

* mempool changes

* Bridge part refactor

* Withdraw-gateways refactor

* Minor translation fixes in Learn folder.

* Zktrie and Zkevm part

* minor corrections in translations of rollup, opcode and hash

* minor corrections in gateway translation

* minor translation corrections

* "SB" changed to ZK in get started, learn and devs

* "Haberci"ler "Messenger"a donusturuldu.

* local preview fixes

* proof read "getting started" "user guide" "learn"

* punctuation mistake while proof reading

* getting started/user guide/learn proofread finished, front page translation updates, menu.ts is translated, some parts of translation.js is translated

* minor changes in index and overview

* tr/technology/chain proofread and corrections completed

* syntax corrections in tr/technology/overview

* Typo correction in chain/blocks

* json translations

* translation json translated

* "Baslayin" changed to "Basla" in Menu

* /tr/technology/bridge proofread completed, corrections made

* /tr/technology/sequencer proofread, corrections completed

* /tr/technology/zkevm and /tr/technology/security proofread and corrections completed

* technology subheaders translation changed

* mini term fix

* Proof read dev

* Warning titles have been changed

* minor changes

* a link, a prefix, and a minor main page correction

* fix: npm run build now works with node 18.14.1

---------

Co-authored-by: emremreistaken <[email protected]>
Co-authored-by: emremre <[email protected]>
Co-authored-by: memduh <[email protected]>
Co-authored-by: bahribugra <[email protected]>
Co-authored-by: Dilara <[email protected]>

* Curie updates (#289)

* Curie updates (#271)

* curie-update-libzkp-version

* security nit

* move contact info into highlight

* change Aside type

* Update running-a-scroll-node.mdx (#278)

* nodeKey hashing are done with domain 512 not 256

Am currently making a storage prover in noir and found this error

In the zktrie repo nodekeys are hashed with ToSecureKey() in type/util.go (afaik)
https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/util.go#L107

ToSecureKey() uses Hash()  in types/bytes32.go which uses HASH_DOMAIN_BYTE32 as domain which is 256 *2 (512)
see here: https://github.com/scroll-tech/zktrie/blob/23181f209e94137f74337b150179aeb80c72e7c8/types/hash.go#L16

and here is where i did my test in noir :D (account leaf is lower in same file)
https://github.com/jimjimvalkema/scrollZkStorageProofs/blob/bcdd922405e046e99787b8b47f374befac170779/ScrollStorageProver/src/main.nr#L168

* add get in touch button

* Revert "add get in touch button"

This reverts commit 5c695f2.

* Curie update details (#286)

* remove legacy flag for foundry

* update Curie details

* fix typo

* oops

* Add PR descriptions

---------

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: Sina Pilehchiha <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: jimjimvalkema <[email protected]>
Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: zhengqi zhang <[email protected]>

* Merge pull request #338 from SahilAujla/develop

add alchemy to scroll tools

* Merge pull request #342 from jlin27/develop

add 0x to dev tooling explorer

* Merge to prod (#349)

* Darwinv2 changes (#332)

* darwinv2 changes

* oops

* note on reorgs and finality

* formatting

* added guide for the graph (#334)

* add alchemy to scroll tools

* update text in alchemy.mdx

* add 0x to dev tooling explorer

* fix feedback

---------

Co-authored-by: AK <[email protected]>
Co-authored-by: Sahil Aujla <[email protected]>
Co-authored-by: emilyJLin95 <[email protected]>
Co-authored-by: Jessica Lin <[email protected]>

* Publish Canvas guide (#371)

* Darwinv2 changes (#332)

* darwinv2 changes

* oops

* note on reorgs and finality

* formatting

* added guide for the graph (#334)

* add alchemy to scroll tools

* update text in alchemy.mdx

* add 0x to dev tooling explorer

* fix feedback

* Guide for adding Canvas badges (#333)

* add Canvas guide

* fix

* add to nav

* display images side by side

* feedback

* add image margins

* fix the title (#337)

* Update the content detail and unbold text (#341)

* fix the title

* Unbold the text under toggle list

* Update the content (#348)

* fix the title

* Unbold the text under toggle list

* Update the content

* small edits

* Apply suggestions from code review

Co-authored-by: Péter Garamvölgyi <[email protected]>

* Isabellewei/canvas (#367)

* fix the title

* Unbold the text under toggle list

* Update the content

* update content based on the comments

---------

Co-authored-by: isabellewei <[email protected]>

---------

Co-authored-by: fanyarachel <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

---------

Co-authored-by: AK <[email protected]>
Co-authored-by: Sahil Aujla <[email protected]>
Co-authored-by: emilyJLin95 <[email protected]>
Co-authored-by: Jessica Lin <[email protected]>
Co-authored-by: fanyarachel <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

* add pyth to scroll

* fix pyth excerpt

* fix typos

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Ahmed Castro <[email protected]>
Co-authored-by: emremreistaken <[email protected]>
Co-authored-by: emremre <[email protected]>
Co-authored-by: memduh <[email protected]>
Co-authored-by: bahribugra <[email protected]>
Co-authored-by: Dilara <[email protected]>
Co-authored-by: isabellewei <[email protected]>
Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: Sina Pilehchiha <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: jimjimvalkema <[email protected]>
Co-authored-by: zhengqi zhang <[email protected]>
Co-authored-by: vincent <[email protected]>
Co-authored-by: ChuhanJin <[email protected]>
Co-authored-by: emilyJLin95 <[email protected]>
Co-authored-by: AK <[email protected]>
Co-authored-by: Sahil Aujla <[email protected]>
Co-authored-by: Jessica Lin <[email protected]>
Co-authored-by: fanyarachel <[email protected]>
Co-authored-by: Morty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants