Contract Upgrade #1449
Merged
Contract Upgrade #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implement UpdateAdmin & ClearAdmin in keeper
# Conflicts: # cosmwasm/enclaves/shared/contract-engine/src/contract_validation.rs # x/compute/internal/keeper/keeper.go # x/compute/internal/types/keys.go # x/compute/internal/types/types.go
Up next: migrate contract key & update validation function on exec
Fixed proto files Added validation for new contract key & proof
(...other tests kind of broken still, but hey, progress)
Added check for admin == sender in keeper Added tests to check that storage can be read post-migration Added test for trying to migrate with different address
assafmo
changed the title
This reverts commit 1c80122.
IBC Hooks: send acks & timeouts to `sudo()` instead of `execute()`
Cashmaney
commented
Aug 2, 2023
For contracts that were deployed before v1.10 and have been migrated using the hardcoded admin feature. These contracts might have other contracts that call them with a wrong code_hash, because those other contracts have it stored from before the migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic functionality of contract upgrades - this adds the functionality needed to do the code replacement. Does not support already-deployed contracts - we still need to figure this out eventually. Nor does it support any kind of different permissions for upgrade - the admin can just do whatever he wants