feat: Do not set title when undefined

fixes #410
scttcper · Nov 15, 2022 · c31dda8 · c31dda8
1 parent a155145
commit c31dda8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/lib/picker/ngx-emoji/emoji.component.ts b/src/lib/picker/ngx-emoji/emoji.component.ts
@@ -43,7 +43,7 @@ export interface EmojiEvent {
       (click)="handleClick($event)"
       (mouseenter)="handleOver($event)"
       (mouseleave)="handleLeave($event)"
-      [title]="title"
+      [attr.title]="title"
       [attr.aria-label]="label"
       class="emoji-mart-emoji"
       [class.emoji-mart-emoji-native]="isNative"
@@ -60,7 +60,7 @@ export interface EmojiEvent {
       (click)="handleClick($event)"
       (mouseenter)="handleOver($event)"
       (mouseleave)="handleLeave($event)"
-      [title]="title"
+      [attr.title]="title"
       [attr.aria-label]="label"
       class="emoji-mart-emoji"
       [class.emoji-mart-emoji-native]="isNative"
@@ -94,7 +94,7 @@ export class EmojiComponent implements OnChanges, Emoji {
   @Output() emojiLeave: Emoji['emojiLeave'] = new EventEmitter();
   @Output() emojiClick: Emoji['emojiClick'] = new EventEmitter();
   style: any;
-  title = '';
+  title?: string = undefined;
   label = '';
   unified?: string | null;
   custom = false;

diff --git a/src/lib/picker/picker.component.html b/src/lib/picker/picker.component.html
@@ -58,7 +58,7 @@
   </section>
   <div class="emoji-mart-bar" *ngIf="showPreview">
     <emoji-preview
-      [title]="title"
+      [attr.title]="title"
       [emoji]="previewEmoji"
       [idleEmoji]="emoji"
       [emojiIsNative]="isNative"

diff --git a/src/lib/picker/skins.component.ts b/src/lib/picker/skins.component.ts
@@ -32,7 +32,7 @@ import { Emoji } from '@ctrl/ngx-emoji-mart/ngx-emoji';
           [attr.aria-haspopup]="!!isSelected(skinTone)"
           [attr.aria-expanded]="expanded(skinTone)"
           [attr.aria-label]="i18n.skintones[skinTone]"
-          [title]="i18n.skintones[skinTone]"
+          [attr.title]="i18n.skintones[skinTone]"
         ></span>
       </span>
     </section>