feat(server-properties): Creation of ServerProperties System

[AzaleeX]

Description

This pull request introduces a new ServerProperties system to manage the server's configuration properties in a more structured and maintainable way. The changes replace the previous use of Config with the newly created ServerProperties class and the associated ServerPropertiesKeys enum.

Key Changes

• Server.java:

  • Replaced the Config instance managing server.properties with ServerProperties.
  • Removed hardcoded property keys and replaced them with keys from ServerPropertiesKeys.
  • Updated methods to use the new ServerProperties system for retrieving and setting configuration properties.

• ServerProperties.java:

  • A new class to handle server properties with predefined default values.
  • Provides methods for retrieving properties with type safety (e.g., String, Integer, Boolean, etc.).
  • Simplifies setting and getting property values with appropriate type casting.

• ServerPropertiesKeys.java:

  • An enum containing all the keys used in the server.properties file.
  • Ensures that all keys are centralized and consistent across the codebase.

Changes Overview

• Files Modified: 2 files modified (Server.java and ServerProperties.java)
• Files Added: 2 files added (ServerProperties.java, ServerPropertiesKeys.java)
• Lines Added: 164 lines
• Lines Removed: 25 lines

Code Review

Additions:

• Server.java:

  • Added import org.sculk.config.ServerProperties;
  • Added import org.sculk.config.ServerPropertiesKeys;
  • Initialized ServerProperties instead of Config for server properties.
  • Updated logging and configuration retrieval methods.

• ServerProperties.java:

  • Added logic for initializing and managing server properties with default values.
  • Created methods for safe retrieval of different data types (e.g., String, Integer, Boolean).

• ServerPropertiesKeys.java:

  • Enum to define keys used in ServerProperties.

Deletions:

• Server.java:
  • Removed hardcoded string literals for property keys.
  • Removed old Config initialization for server.properties.

Testing

• Tested the new ServerProperties system with existing server configurations.
• Ensured all properties load correctly with their respective types.
• Verified that default values are applied when properties are missing.

@AzaleeX