Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
@SanderElias I suggest to include MinifyHtml plugin as official
@scullyio
plugin since it is a useful plugin for the Scully ecosystem but seems to be no longer maintained while having certain issues.I submit a PR that includes the plugin source code, docs for using it and build configs.
Besides that I updated it to use
postProcessByHtml
plugin type instead of deprecatedrender
so Scully no longer gives a warning when running it with this plugin. (Related to original issue)Also I fixed the bug where this plugin was messing with the transfer state script, so adding
{minifyJS: true}
is no longer required for Scully to work properly with this plugin.I tested it locally with one of my projects and it worked with a small note, that when I used it via
npm link
Scully complained thatplugin minifyHtml was not found
, so I had to addregisterPlugin
manually in my project's config, but I believe it's due to hownpm link
works, plugin was registering itself in different instance of scully installation than what my project used.