Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to harmony time points dtype #1248

Merged
merged 15 commits into from
Oct 6, 2020
Merged

fix to harmony time points dtype #1248

merged 15 commits into from
Oct 6, 2020

Conversation

awnimo
Copy link
Contributor

@awnimo awnimo commented May 25, 2020 •
edited
Loading

Harmony issue#14

@Koncopd
Copy link
Member

Koncopd commented Oct 2, 2020

Hi, @awnimo , sorry for the delay.
It seems that this PR breaks test_harmony_timeseries.py. I get

E           ValueError: 'time_points' column does not contain Categorical data

../../external/tl/_harmony_timeseries.py:140: ValueError

On master the test works fine.
Could you check and fix this?

@awnimo
Copy link
Contributor Author

awnimo commented Oct 5, 2020

Hi @Koncopd ,

The error fixed here df8bbaf.

Thank you!

Hi, @awnimo , sorry for the delay.
It seems that this PR breaks test_harmony_timeseries.py. I get

E           ValueError: 'time_points' column does not contain Categorical data

../../external/tl/_harmony_timeseries.py:140: ValueError

On master the test works fine.
Could you check and fix this?

@Koncopd Koncopd merged commit 746bc9a into scverse:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awnimo @Koncopd