Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of colorbar logic #349

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactoring of colorbar logic #349

wants to merge 1 commit into from

Conversation

timtreis
Copy link
Member

@timtreis timtreis commented Sep 4, 2024 •
edited
Loading

Before
image

After
image

@timtreis timtreis linked an issue Sep 4, 2024 that may be closed by this pull request
Enhancement: Make colorbar the same height as the ax #348
Open
@giovp
Copy link
Member

giovp commented Sep 5, 2024

magic 🤩

@timtreis timtreis linked an issue Sep 6, 2024 that may be closed by this pull request
legend height cannot be adjusted #318
Open
@timtreis timtreis marked this pull request as draft September 14, 2024 16:39
@timtreis timtreis mentioned this pull request Sep 27, 2024
Open
@timtreis timtreis changed the title Colorbar is now the same height as the ax object Refactoring of colorbar logic Oct 2, 2024
@timtreis timtreis self-assigned this Oct 23, 2024
@LucaMarconato
Copy link
Member

Tasks missing to close this PR:

  • right now, the colobar gets defined in 2 places in the codebase -> unify

Additional task, suitable for the Basel Hackathon:

  • establish set of parameters relevant for cbar: distance from plot (probably just scalar that multiplied a fixed), cbar width, cbar title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Basel Hackathon Nov 2024
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Make colorbar the same height as the ax legend height cannot be adjusted
3 participants
@timtreis @giovp @LucaMarconato