Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for plotting columns from points #395

Merged
merged 7 commits into from
Dec 26, 2024

Conversation

LucaMarconato
Copy link
Member

Reproduces #394, details described in the issue.

@LucaMarconato
Copy link
Member Author

@melonora @Sonja-Stockhaus this issue is unfortunately affecting some notebooks from the docs and therefore blocking a release.

@melonora could you please regenerate the artifacts? This would fix 3 out of 4 tests.
@Sonja-Stockhaus could you please have a look at the other test (categorical column, datashader)?

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (62e8b5a) to head (6ab64b8).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   83.56%   83.75%   +0.19%     
==========================================
  Files           8        8              
  Lines        1691     1693       +2     
==========================================
+ Hits         1413     1418       +5     
+ Misses        278      275       -3     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 90.76% <100.00%> (+0.87%) ⬆️

@LucaMarconato
Copy link
Member Author

Fixed! I will make a release.

@LucaMarconato LucaMarconato merged commit 16d057e into main Dec 26, 2024
3 of 5 checks passed
@LucaMarconato LucaMarconato deleted the tests_for_plotting_points_columns branch December 26, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants