Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures adain_npy returned pixel value is within the range of bit depth #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kennethxu
Copy link

@kennethxu kennethxu commented Aug 9, 2024

This fixes #222. The normalization process of adain_npy could generate pixel values that are out of the range of original image bit depth. For example, it computed values less than 0 or greater than 256 for 8-bit images. When this happens, the later process will consider the image to be 16 bit depth. But since most of pixels are less than 256, which is effectively black in 16 bit (65536) space, the result is an entirely black image. The solution is to compute a proper ratio to reduce style_std so that no pixel would exceed the range of original bit depth while still apply the style in the best effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of Codeformer is a black image
1 participant