-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homebrew support #1042
Add Homebrew support #1042
Conversation
Watch out for jreleaser/jreleaser#702 when upgrading to JReleaser |
Alternatively we could introduce another flag for disabling the |
Hi @marc0der, I've added some tests to make sure that the old behaviour doesn't break. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. We shouldn't forget to add the new config to the sdkman-hooks service as mentioned.
@marc0der With the hook updates promoted to stable, I wonder if
the Would be nice if we could get rid of that OR expression. |
@helpermethod You are right. The selfupdate should take care of it, provided we deploy the hooks before the CLI. That said, I suggest leaving it in until both have been deployed, then removing it in a tiny follow-up PR once the dust has settled. |
Too late, already removed it 😂 |
@helpermethod You are too fast 😆 You probably need to update the |
Removed the |
Oh, and before we finally do the release I need to drop the old SDKMAN! Homebrew repository. |
Okay, are you happy for me to merge that so we can test it in the beta channel? |
Let's go! |
Because some breaking changes were introduced in sdkman/sdkman-cli#1042.
This was a breaking change for me, sad it wasn't tagged as one. I think it should be avoided to perform breaking changes without bumping the major version (like from 5 to 6). |
Sorry to hear 😥! The That's why we didn't bump the major version. |
That's ok, it's not the first time anyway. #1069 kind of prevents it (in the sense that if someone didn't touch the default configuration, it will be handled by the migration). But only in that case. |
By the way, docs are missing the new |
* Ensure `selfupdate` is enabled for SDKMAN! This subcommand is unavailable when the `sdkman_selfupdate_feature` option is disabled, as is the case when SDKMAN! is installed via Homebrew. sdkman/sdkman-cli#1042 * Fix macOS build; simplify Co-authored-by: Roey Darwish Dror <[email protected]>
* Ensure `selfupdate` is enabled for SDKMAN! This subcommand is unavailable when the `sdkman_selfupdate_feature` option is disabled, as is the case when SDKMAN! is installed via Homebrew. sdkman/sdkman-cli#1042 * Fix macOS build; simplify Co-authored-by: Roey Darwish Dror <[email protected]>
JRELEASER_HOMEBREW_GITHUB_TOKEN
sdkman_selfupdate_feature
flag to disableselfupdate
functionality (includingauto_update
)keepsdkman_selfupdate_enable
flag for backwards-compatibilitysdkman_auto_update
flag for enabling/disablingauto_update
(replacessdkman_selfupdate_enable
)