Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Liquibase Candidate #683

Closed
wants to merge 5 commits into from

Conversation

jandroav
Copy link

Hello team, we have a question about https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives.

We are already generating a zip file for liquibase. It almost complies with the Well-formed-SDK-archives guide except for the bin folder. We are shipping the executable in the root folder:

image

We are ok if we need to generate a different zip file for SDKMAM like the following:

image

But we would like to know if we could create a bin directory and symlink the required files into it (or move to bin and symlink to root dir). This involves the creation of a tar. which supports symbolic links instead of a zip file.

…igration001 method to insert Liquibase candidate into the database
@helpermethod
Copy link
Member

Hi @jandroav!

Because the respective bin directory is added to PATH by SDKMAN!, I suppose this should work out of the box.

@jandroav
Copy link
Author

Thanks @helpermethod !

Is there anything else we need to do to have liquibase available in SDKMAN!?

…r consistency

refactor(LiquibaseMigrations.scala): update Liquibase description for clarity and conciseness
@marc0der
Copy link
Member

Hi @jandroav 👋
All that remains is requesting API keys to start publishing your versions. I'll do a quick stab to see if adding that bin folder with symlinks would work, although I suspect it would break on Windows (symlinks not supported). If not, you would need to provide a special zip archive that has the executable in the bin folder.

@marc0der
Copy link
Member

Formatting failure @jandroav. Please see the README on how to run scalafmt.

…lity and consistency in indentation and spacing
@jandroav
Copy link
Author

Formatting fixed and API creds requested. Thanks for your quick review on this @marc0der !

@marc0der
Copy link
Member

Hi @jandroav, it looks like your code doesn't compile. You might need to look at some of the other migrations to see how it's done. You should probably use IntelliJ or VSCode with Metals. If not, at least use SBT to build and verify that it's correct. All instructions are in the README.

jandroav added 2 commits February 27, 2024 07:18
…claration for consistency

feat(LiquibaseMigrations.scala): add Liquibase migration change log for version 1.2.3 by jandroav
…move version number for consistency and clarity
@jandroav
Copy link
Author

Hi @marc0der, sorry, imports were missing. Now it builds.

@jandroav
Copy link
Author

Hey @marc0der I see one build issue but I am not sure if it is related to my changelog: https://github.com/sdkman/sdkman-db-migrations/actions/runs/8060565235/job/22024825534

@helpermethod
Copy link
Member

Hi @jandroav! The error is unrelated to your PR.

@jandroav
Copy link
Author

jandroav commented Mar 1, 2024

Thanks @helpermethod !

How long does it usually take to have the PR merged and ready to upload versions to SDKMAN!?

I also sent an email from my liquibase email with our public key in plain text format.

@jnewton03
Copy link

hi @helpermethod @marc0der 😄 . Anything we can do to help get this moved forward? Thanks so much for your help!

@marc0der
Copy link
Member

marc0der commented Mar 7, 2024

@jnewton03 @jandroav The problem was due to a dodgy migration, which I've now removed. I also rebased your PR against the updated master and merged it. GitHub doesn't always pick rebases so I'll close this PR now that it is merged.

@marc0der marc0der closed this Mar 7, 2024
@jandroav
Copy link
Author

jandroav commented Mar 7, 2024

Thanks @marc0der ! We sent the last feb 26 a mail with our public key as shown here https://github.com/sdkman/sdkman-cli/wiki/Vendor-onboarding-process but we did not get a reply. Is there anything else we need to do to be able to send liquibase versions?

@marc0der
Copy link
Member

marc0der commented Mar 7, 2024

No probs, I'll look into it shortly.

@jandroav
Copy link
Author

Hi there, just a quick follow-up to remind you that we're eagerly awaiting approval of our public key to start using SDKMAN! for distributing Liquibase. Your assistance with this would be greatly appreciated. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants