graphs1090 reduce io logic fix #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the readback fails, the writeback won't happen thus make readback fails fatal. (they should really not happen) like this no graphs will be shown which is likelier to get the users attention than for example graphs without old data showing
changed that in a previous commit due to build caching but less layers trump the build caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the readback fails, the writeback won't happen
Thus make readback fails fatal and not start collectd in this case.
Readback fails should pretty much never happen :/
Like this no graphs will be shown which is likelier to get the users
attention than for example graphs without old data showing.