Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better frame rate handling than busy-waiting for an assumed 60 FPS #128

Open
twaritwaikar opened this issue Nov 10, 2019 · 0 comments
Open

Add better frame rate handling than busy-waiting for an assumed 60 FPS #128

twaritwaikar opened this issue Nov 10, 2019 · 0 comments
Labels
enhancement New feature or request subject: API Related to the API exposed to the user subject: Awerere Related to the physics engine subject: Guerrilla Renderer Related to the main rendering engine

Comments

@twaritwaikar
Copy link
Member

Master HEAD: v2

This:

Rubeus/RubeusCore/Source/Architecture/engine.cpp

Line 125 in 5f791c5

if(glfwGetTime() - lastFrameEndTime >= 1.0f / 60.0f)

...is assuming 60 FPS as the base FPS and attempts to busy-wait if the game exceeds 60 FPS.

Add a way to lower this limit in case the frame rate is set to something lower, or the FPS is not really being met to 60 FPS
@twaritwaikar twaritwaikar added enhancement New feature or request subject: API Related to the API exposed to the user subject: Awerere Related to the physics engine subject: Guerrilla Renderer Related to the main rendering engine labels Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request subject: API Related to the API exposed to the user subject: Awerere Related to the physics engine subject: Guerrilla Renderer Related to the main rendering engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twaritwaikar